Hasen

Fluff

Fussing over irrelevant details (fluff) creates a toxic culture.

Focus on the essence.

When you review code, what do you look for? The "shape" of the code? The whitespace? The indentation levels? The length of functions? All these things are irrelevant.

Look at what the code is actually doing. How data is flowing across the system. Is the way it's implemented likely to cause problems? Performance issues? Too complicated code to do a very simple thing? Can it be simplified? Is it even doing the correct thing? Is there an obvious mistake you can spot?

That said, you should not be doing that many code reviews in the first place.

Code review on every commit/push means you don't trust the competence of the people on your team. It's a form of micromanagement.

Hire people you can trust.

#team-values